RFR: 8324242: Avoid null check for OopHandle::ptr_raw() [v2]

Aleksey Shipilev shade at openjdk.org
Tue Jan 23 19:50:26 UTC 2024


On Tue, 23 Jan 2024 19:00:43 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to use OopHandle::is_empty() rather than comparing
>> the result of OopHandle::ptr_raw() with nullptr.  While equivalent, the former
>> is the intended API for such checks.  ptr_raw should only be used directly
>> where it is actually needed.
>> 
>> Testing: mach5 tier1.
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> 
>   tidy CLD remove_handle

Looks okay. Pity we were not able to eliminate the `ptr_raw` use completely.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17510#pullrequestreview-1839794218


More information about the hotspot-dev mailing list