RFR: 8319801: Recursive lightweight locking: aarch64 implementation [v6]
Axel Boldt-Christmas
aboldtch at openjdk.org
Wed Jan 24 14:19:31 UTC 2024
On Wed, 24 Jan 2024 11:29:41 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream_jdk/pr/16606' into JDK-8319801
>> - Switch to CAS over LXSX
>> - Fix missing $
>> - Merge remote-tracking branch 'upstream_jdk/pr/16606' into JDK-8319801
>> - Merge remote-tracking branch 'upstream_jdk/pr/16606' into JDK-8319801
>> - Merge remote-tracking branch 'upstream_jdk/pr/16606' into JDK-8319801
>> - Merge remote-tracking branch 'upstream_jdk/pr/16606' into JDK-8319801
>> - Merge remote-tracking branch 'upstream_jdk/pr/16606' into JDK-8319801
>> - 8319801: Recursive lightweight locking: aarch64 implementation
>> - Cleanup: C2 fast_lock/fast_unlock aarch64
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 68:
>
>> 66: #endif
>> 67:
>> 68: #include <sys/types.h>
>
> Is that import even used? I can't spot it.
This was simply to correct the include order of the already included includes. `#include <sys/types.h>` appeared above the precompiled header include. The rule is to have system includes below the ordinary includes with one new empty line in-between.
Might very well be that this include is not used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16608#discussion_r1464978772
More information about the hotspot-dev
mailing list