RFR: 8324492: Remove Atomic support for OopHandle [v2]

[Kim Barrett]

On Wed, 24 Jan 2024 11:26:10 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   aboldtch review
>
> src/hotspot/share/services/memoryManager.cpp line 147:
> 
>> 145:     } else {
>> 146:       // Record the object we created via call_special.
>> 147:       _memory_mgr_obj = mgr_handle;
> 
> Could assert that `_memory_mgr_obj.is_empty()`.

Done.

> src/hotspot/share/services/memoryManager.hpp line 66:
> 
>> 64: 
>> 65: public:
>> 66:   virtual ~MemoryManager() = default; // FIXME
> 
> Was this added because we are deleting these objects through the base class pointer? Or just in case?
> 
> Regardless what is the `FIXME` comment for?

Oops, that was a piece of another change that I started but abandoned for now.
Removed.

> src/hotspot/share/services/memoryPool.cpp line 142:
> 
>> 140:     } else {
>> 141:       // Record the object we created via call_special.
>> 142:       _memory_pool_obj = pool_handle;
> 
> Could assert that `_memory_pool_obj.is_empty()`.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17533#discussion_r1465870877
PR Review Comment: https://git.openjdk.org/jdk/pull/17533#discussion_r1465871728
PR Review Comment: https://git.openjdk.org/jdk/pull/17533#discussion_r1465870974