RFR: 8324678: Replace NULL with nullptr in HotSpot gtests

Coleen Phillimore coleenp at openjdk.org
Fri Jan 26 21:20:42 UTC 2024


On Fri, 26 Jan 2024 20:41:17 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> If this is sufficient, here's the change for NULL to nullptr, adjusting some obvious strings that had NULL in them maybe not all.
>> Tested with gtest,
>
> test/hotspot/gtest/runtime/test_os_linux.cpp line 203:
> 
>> 201:       HugeTlbfsMemory mr(p, size);
>> 202:       // as the area around req_addr contains already existing mappings, the API should always
>> 203:       // return nullptr (as per contract, it cannot return another address)
> 
> s/nullptr/null/

This is technically correct.  Changing the comments like this seems really pointless.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17577#discussion_r1468156011


More information about the hotspot-dev mailing list