RFR: 8319799: Recursive lightweight locking: x86 implementation [v14]

Daniel D. Daugherty dcubed at openjdk.org
Fri Jan 26 21:38:46 UTC 2024


On Thu, 25 Jan 2024 15:19:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ah, nevermind. Leave it with extra argument for thread, then.
>
> I sort of liked the extra thread parameter so that the callers know that !LP64 needs get_thread() and not the lightweight_{un}lock.  It's unfortunately inconsistent and requires an extra register, but nice that you can call it 'thread', at least until you overwrite it.

I also like the thread parameter for the same reasons as @coleenp. I think making the
nonsense we have to go thru for 32-bit/low-register-count platforms more obvious is better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16607#discussion_r1467062134


More information about the hotspot-dev mailing list