RFR: JDK-8324287: Record total and free swap space in JFR [v2]
Matthias Baesken
mbaesken at openjdk.org
Mon Jan 29 08:41:29 UTC 2024
On Fri, 26 Jan 2024 14:43:50 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Total and free swap space should be recorded in JFR, because it is important to know e.g. in case of memory shortages.
>>
>> Currently we only have a container related event (ContainerMemoryUsage) that provides some info but no general event.
>> PhysicalMemory could be enhanced or a new event added.
>>
>> There is already some coding (see Java_com_sun_management_internal_OperatingSystemImpl_getTotalSwapSpaceSize0 and
>> Java_com_sun_management_internal_OperatingSystemImpl_getFreeSwapSpaceSize0) for the swap space info retrieval.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> remove comment
Thanks for the review !
One remaining question is (os_linux) "do we need to handle container envs separately ?"
Will maybe ask Severin gehwolf about his opinion.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17581#issuecomment-1914209919
More information about the hotspot-dev
mailing list