RFR: JDK-8324287: Record total and free swap space in JFR [v2]
Matthias Baesken
mbaesken at openjdk.org
Mon Jan 29 13:26:35 UTC 2024
On Mon, 29 Jan 2024 09:22:20 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove comment
>
> src/hotspot/os/aix/os_aix.cpp line 281:
>
>> 279: return -1;
>> 280: }
>> 281: return (jlong)(memory_info.pgsp_total * 4L * 1024L);
>
> please use 4 * K instead of 4L * 1024L. K is declared as size_t in globalDefinitions.hpp.
Thanks Lucy, I replaced it.
I noticed we have a similar code in jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c should I replace this (probably in a separate change) ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17581#discussion_r1469587227
More information about the hotspot-dev
mailing list