Integrated: 8324840: windows-x64-slowdebug does not build anymore after JDK-8317572

[Emanuel Peter]

On Mon, 29 Jan 2024 14:04:19 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Hi all,
>> 
>>   after [JDK-8317572](https://bugs.openjdk.org/browse/JDK-8317572) windows-x64-slowdebug does not build any more with teh following error:
>> 
>>  ```
>> [2024-01-29T12:19:47,671Z] Creating support/native/java.desktop/libjsound/static/jsound.lib from 17 file(s)
>> [2024-01-29T12:24:59,378Z] ...\open\src\hotspot\share\utilities/stringUtils.hpp(65): error C3861: 'strtok_r': identifier not found
>> [2024-01-29T12:24:59,378Z] ...\open\src\hotspot\share\utilities/stringUtils.hpp(73): error C3861: 'strtok_r': identifier not found
>> [2024-01-29T12:24:59,378Z] lib/CompileJvm.gmk:152: recipe for target '.../windows-x64-slowdebug/hotspot/variant-server/libjvm/objs/static/logLevel.obj' failed
>> [2024-01-29T12:24:59,378Z] make[3]: *** [.../windows-x64-slowdebug/hotspot/variant-server/libjvm/objs/static/logLevel.obj] Error 1
>> [2024-01-29T12:24:59,378Z] make[3]: *** Waiting for unfinished jobs....
>> [2024-01-29T12:25:02,568Z] make/Main.gmk:261: recipe for target 'hotspot-server-static-libs' failed
>> [2024-01-29T12:25:02,568Z] make[2]: *** [hotspot-server-static-libs] Error 2
>> [2024-01-29T12:25:02,568Z] make[2]: *** Waiting for unfinished jobs....
>> [2024-01-29T12:25:03,412Z] ...\open\src\hotspot\share\utilities/stringUtils.hpp(65): error C3861: 'strtok_r': identifier not found
>> [2024-01-29T12:25:03,412Z] ...\open\src\hotspot\share\utilities/stringUtils.hpp(73): error C3861: 'strtok_r': identifier not found
>> [2024-01-29T12:25:03,412Z] lib/CompileJvm.gmk:152: recipe for target '.../windows-x64-slowdebug/hotspot/variant-server/libjvm/objs/logLevel.obj' failed
>> [2024-01-29T12:25:03,412Z] make[3]: *** [.../windows-x64-slowdebug/hotspot/variant-server/libjvm/objs/logLevel.obj] Error 1
>> ``` 
>> 
>> This change adds the necessary includes.
>> 
>> Still compiling the change....
>> 
>> Thomas
>
> Shouldn't this have used strtok_s?
> https://github.com/openjdk/jdk/blob/fe0eec7e20bc4c39d6c2b58d81ffd5c0ef1fdeda/src/hotspot/share/runtime/os.hpp#L1014

@TheShermanTanker maybe so, have not looked into that. I only moved code in [JDK-8317572](https://bugs.openjdk.org/browse/JDK-8317572), which led to include issues here.

@TheShermanTanker does the code you quote not exactly make sure that if we write `strtok_r` on windows, that we actually use `strtok_s`, and so everything is ok?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17613#issuecomment-1914773536
PR Comment: https://git.openjdk.org/jdk/pull/17613#issuecomment-1914778290