RFR: 8319799: Recursive lightweight locking: x86 implementation [v14]

Axel Boldt-Christmas aboldtch at openjdk.org
Mon Jan 29 14:50:57 UTC 2024


On Mon, 29 Jan 2024 14:38:02 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp line 142:
>> 
>>> 140: #else
>>> 141:     // This relies on the implementation of lightweight_unlock knowing that it
>>> 142:     // will clobber its thread when using EAX.
>> 
>> This use of `EAX` is confusing when earlier in this function `rax` is used.
>
> Hm, I thought RAX was confusing when used in x86_32 code. But can try to clarify.

Tried to reword and restructure the comments surrounding this a bit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16607#discussion_r1469702789


More information about the hotspot-dev mailing list