RFR: 8324865: windows-x64-slowdebug still does not build after JDK-8324840 [v2]

[David Holmes]

On Mon, 29 Jan 2024 23:52:54 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> [~jwaters] commented in the PR [#17613](https://github.com/openjdk/jdk/pull/17613) that on windows we have strtok_s instead of strtok_r. We may need to #include "runtime/os.hpp" which defined strtok_r for windows instead of <string.hpp>. 
>> 
>> Including os.hpp will increase compilation time for all files which inclide "stringUtils.hpp".
>> I suggest to move code from .hpp to .cpp file. It is used only by c2 and inlining of this code is not too important.
>> 
>> Tested tier1 and tier2 builds with precompiled headers off.
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update fix

One nit else good.

Thanks

src/hotspot/share/utilities/stringUtils.hpp line 31:

> 29: 
> 30: #ifdef _WINDOWS
> 31:   // strtok_s is the Windows thread-safe equivalent of POSIX strtok_r

Nit: indent needs fixing

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17622#pullrequestreview-1850025506
PR Review Comment: https://git.openjdk.org/jdk/pull/17622#discussion_r1470419183