RFR: 8324865: windows-x64-slowdebug still does not build after JDK-8324840 [v2]

Vladimir Kozlov kvn at openjdk.org
Tue Jan 30 01:11:42 UTC 2024


On Tue, 30 Jan 2024 00:34:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update fix
>
> src/hotspot/share/utilities/stringUtils.hpp line 31:
> 
>> 29: 
>> 30: #ifdef _WINDOWS
>> 31:   // strtok_s is the Windows thread-safe equivalent of POSIX strtok_r
> 
> Nit: indent needs fixing

@dholmes-ora  Do you mean to remove 2 spaces before `//`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17622#discussion_r1470444888


More information about the hotspot-dev mailing list