Integrated: 8324865: windows-x64-slowdebug still does not build after JDK-8324840
Vladimir Kozlov
kvn at openjdk.org
Tue Jan 30 01:11:43 UTC 2024
On Mon, 29 Jan 2024 22:38:27 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> [~jwaters] commented in the PR [#17613](https://github.com/openjdk/jdk/pull/17613) that on windows we have strtok_s instead of strtok_r. We may need to #include "runtime/os.hpp" which defined strtok_r for windows instead of <string.hpp>.
>
> Including os.hpp will increase compilation time for all files which inclide "stringUtils.hpp".
> I suggest to move code from .hpp to .cpp file. It is used only by c2 and inlining of this code is not too important.
>
> Tested tier1 and tier2 builds with precompiled headers off.
This pull request has now been integrated.
Changeset: b6d364ad
Author: Vladimir Kozlov <kvn at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/b6d364ad88ca0e554a47ef7daba03bb07fd95b01
Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
8324865: windows-x64-slowdebug still does not build after JDK-8324840
Reviewed-by: dholmes, dcubed
-------------
PR: https://git.openjdk.org/jdk/pull/17622
More information about the hotspot-dev
mailing list