RFR: 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark
Coleen Phillimore
coleenp at openjdk.org
Tue Jan 30 16:17:04 UTC 2024
On Mon, 29 Jan 2024 18:34:02 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> The issue is reproduced with
> make -- run-test JTREG_VERBOSE=all JTREG_RETAIN=all TEST=runtime/ConstantPool/TestMethodHandleConstant.java TEST_VM_OPTS="-Xlog:all=trace:file=vm.%p.log"
>
> verified that it doesn't crash anymore. Also, run tier1 for sanity testing.
This looks good. I thought we decided that all of the print_on(outputStream*) functions should not have a ResourceMark so that their callers can resource allocate a stream to print to. Maybe that changed with stringStream and logging (?)
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17620#pullrequestreview-1851455231
More information about the hotspot-dev
mailing list