RFR: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread [v2]

David Holmes dholmes at openjdk.org
Wed Jan 31 01:40:02 UTC 2024


On Tue, 30 Jan 2024 15:34:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> hm, LEGACY doesn't use locking_thread.
>
> Maybe this would make more sense to me as Thread* current staying the first parameter, and the second parameter is fast_locking_thread which can be nullptr.

I agree this doesn't quite makes sense to me. `locking_thread` is really `presumed_owner_thread` - we aren't trying to lock here, we are inflating an already locked object, where the passed in thread is the owner.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17626#discussion_r1472198565


More information about the hotspot-dev mailing list