RFR: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread [v2]

[Richard Reingruber]

On Wed, 31 Jan 2024 01:37:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I'm very frustrated that this code got broken the way it has been.

@dholmes-ora I've introduced the code and I am very offended about the way you express your feelings here and elsewhere about it. People reading this will get the impression that JDK-8227745 is just very inferior in its implementation which it isn't. A lot of work went into it. I wish you had helped reviewing it better. It is my impression that you hardly ever take the time that is necessary to look at the code and think about it before commenting. Am truely offended.

In fact there's nothing wrong with one thread inflating a lock on behalf of another thread. It's just the usage of ResourceMark that is wrong. And that is a pretty minor bug. Nothing to be very frustrated about really. Let's just fix it! I'm d'accord to have a specialized version to do the job if the acting thread is not the same as the lock owner. @xmas92's fix isn't that bad either modulo naming of variables but that again isn't anything to get frustrated about.

Thanks, Richard.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17626#issuecomment-1918703033