RFR: 8324833: Signed integer overflows in ABS
Andrew Haley
aph at openjdk.org
Wed Jan 31 11:40:04 UTC 2024
On Mon, 29 Jan 2024 15:59:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> See the details in the bug. I think current `ABS` implementation is beyond repair, and we should just switch to `uabs`.
>
> Additional testing:
> - [x] Linux x86_64 fastdebug, `all` with `-ftrapv` (now fully passes!)
> - [ ] Linux x86_64 fastdebug, `all`
Looks good. All of these are improvements, I think.
-------------
Marked as reviewed by aph (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17617#pullrequestreview-1853528192
More information about the hotspot-dev
mailing list