RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v13]

Suchismith Roy sroy at openjdk.org
Wed Jan 31 15:09:09 UTC 2024


On Wed, 31 Jan 2024 13:20:52 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spelling
>
> src/hotspot/os/aix/os_aix.cpp line 1176:
> 
>> 1174:   strncpy(file_path,filename, buffer_length + 1);
>> 1175:   char* const pointer_to_dot = strrchr(file_path, '.');
>> 1176:   assert(pointer_to_dot != nullptr, "Attempting to load a shared object without extension? %s", filename);
> 
> This should not only be an assertion. I think the check could be used instead of the strcmp below.

I didn't follow that. You mean i need to keep a check if it is null and print it out ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1472963709


More information about the hotspot-dev mailing list