RFR: 8324833: Signed integer overflows in ABS [v2]

Vladimir Kozlov kvn at openjdk.org
Wed Jan 31 18:38:01 UTC 2024


On Wed, 31 Jan 2024 15:55:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the details in the bug. I think current `ABS` implementation is beyond repair, and we should just switch to `uabs`.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 fastdebug, `all` with `-ftrapv` (now fully passes!)
>>  - [x] Linux x86_64 fastdebug, `all`
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Unnecessary comment

Looks good. I submitted testing.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17617#pullrequestreview-1854554005


More information about the hotspot-dev mailing list