RFR: 8331126: [s390x] secondary_super_cache does not scale well [v4]

Andrew Haley aph at openjdk.org
Mon Jul 1 08:49:26 UTC 2024


On Mon, 24 Jun 2024 14:02:15 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/cpu/s390/macroAssembler_s390.cpp
>>  - rename: r_scratch to r_result in repne_scan method
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3275:
> 
>> 3273:   call_stub(StubRoutines::lookup_secondary_supers_table_slow_path_stub());
>> 3274: 
>> 3275:   z_bru(L_done); // pass whatever result we got from a slow path
> 
> This one branch could be saved by using "load immediate on condition". But it's after slow path processing.

As @RealLucy says, this is after slow processing. It's not worth optimizing here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19544#discussion_r1660693537


More information about the hotspot-dev mailing list