RFR: 8335108: Build error after JDK-8333658 due to class templates

[David Holmes]

On Tue, 25 Jun 2024 18:52:20 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

> Hi all, 
> 
> This PR addresses [8335108](https://bugs.openjdk.org/browse/JDK-8335108). 
> 
> The error arises as template-id is not allowed for constructor/destructor in C++20. 
> 
> Testing: 
> - [x] Compilation succeeds with g++ 14.1.1.
> 
> Thanks, 
> Sonia

The 24-hour rule is mentioned here:

https://openjdk.org/guide/#life-of-a-pr

6. Allow enough time for review

In general all PRs should be open for at least 24 hours to allow for reviewers in all time zones to get a chance to see it. It may actually happen that even 24 hours isn’t enough. Take into account weekends, holidays, and vacation times throughout the world and you’ll realize that a change that requires more than just a trivial review may have to be open for a while. In some areas [trivial] changes are allowed to be pushed without the 24 hour delay. Ask your reviewers if you think this applies to your change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19890#issuecomment-2205119100