RFR: 8334738: os::print_hex_dump should optionally print ASCII [v2]

[Thomas Stuefe]

On Wed, 3 Jul 2024 03:07:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> There is a one-in-2^(32|64) chance the errval numerical value happend to be in memory. By reading twice, with different errval, we diminish the chance of mistaking a successful read for an error.
>
> Ouch! So all the other places we only use SafetchN once are potentially broken? Or is this is special case where any value in memory could theoretically be valid?

Well, maybe I am just overly careful. After all, the chance is infinitesimally small. You are probably in the clear unless you use 0 or some other frequent pattern.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19835#discussion_r1663506578