RFR: 8335397: Improve reliability of TestRecursiveMonitorChurn.java [v2]

Axel Boldt-Christmas aboldtch at openjdk.org
Wed Jul 3 07:25:48 UTC 2024


On Wed, 3 Jul 2024 07:16:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/prims/whitebox.cpp line 1858:
>> 
>>> 1856: 
>>> 1857: WB_ENTRY(jlong, WB_getInUseMonitorCount(JNIEnv* env, jobject wb))
>>> 1858:   return (jlong) WhiteBox::get_in_use_monitor_count();
>> 
>> Why the indirection?
>
> Ah now I see. We need the member function to make it a friend.

Yeah. But your comment made me realise that I could have friended the `friend jlong WB_getInUseMonitorCount(JNIEnv* env, jobject wb)` function directly. But I think this is fine as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19965#discussion_r1663656789


More information about the hotspot-dev mailing list