RFR: 8322475: Extend printing for System.map [v6]

[Thomas Stuefe]

On Tue, 2 Jul 2024 15:11:13 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
>> 
>>  - feedback johan
>>  - fix merge errors
>>  - Merge branch 'master' into System.maps-more-info
>>  - copyrights
>>  - Merge branch 'master' into System.maps-more-info
>>  - fix merge issue
>>  - Merge branch 'master' into System.maps-more-info
>>  - fix whitespace issue
>>  - wip
>>  - exhuming
>>  - ... and 13 more: https://git.openjdk.org/jdk/compare/c6f3bf4b...940199de
>
> src/hotspot/os/linux/procMapsParser.hpp line 66:
> 
>> 64:     from = to = nullptr;
>> 65:     prot[0] = filename[0] = '\0';
>> 66:     kernelpagesize = rss = private_hugetlb = anonhugepages = swap = 0;
> 
> `private_hugetlb` and `shared_hugetlb` missing in reset. Intentional?

No :( good catch. That is why I prefer memsetting, but folks don't like that.

> test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java line 31:
> 
>> 29: 
>> 30: import java.io.*;
>> 31: import java.lang.StringBuilder;
> 
> Nit: `java.lang.*` are imported by default. I don't see it used, so maybe a left over?

Yep, a bunch of those are not needed anymore.

> test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java line 53:
> 
>> 51:         regexBase_committed + "\\[stack\\]",
>> 52:         // we should see the hs-perf data file, and it should appear as shared as well as committed
>> 53:         regexBase_shared_and_committed + "hsperfdata_.*"
> 
> Suggestion: Should the test run with `-XX:+UsePerfData` since it's expecting this file. It's default on, but that might change.

That is a good point.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17158#discussion_r1663668311
PR Review Comment: https://git.openjdk.org/jdk/pull/17158#discussion_r1663664444
PR Review Comment: https://git.openjdk.org/jdk/pull/17158#discussion_r1663662914