RFR: 8334738: os::print_hex_dump should optionally print ASCII [v3]

[Thomas Stuefe]

On Tue, 25 Jun 2024 06:53:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   exclude test for AIX
>
> src/hotspot/share/runtime/os.cpp line 961:
> 
>> 959:   union {
>> 960:     uint64_t v;
>> 961:     uint8_t c[sizeof(v)];
> 
> Why `uint8_t` instead of `unsigned char`?

@dholmes-ora I missed your question, sorry. Both are the same, obviously, but I vaguely prefer uint8_t since its a bit shorter and has the size in its name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19835#discussion_r1665186434