RFR: 8332689: RISC-V: Use load instead of trampolines [v22]
Robbin Ehn
rehn at openjdk.org
Thu Jul 4 13:24:22 UTC 2024
On Thu, 4 Jul 2024 13:18:57 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Seems no need to worry about that? I think it's up to the caller to decide if it wants compressed instructions.
>> Here in this case, the only call site is within a relocate() which will disable compressed instructions for you[1].
>>
>> relocate(entry.rspec(), [&] {
>> load_link_jump(target);
>> });
>>
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/assembler_riscv.hpp#L2130
>
> When you use reloc_call the size of the call must be an exact size we already specified (3 * NativeInstruction::instruction_size). (if those sizes don't apply you don't want a reloc_call)
> So there is nothing to choose from the caller prespective.
Maybe in the future load_link_jump will be used out side reloc_call, was that your thinking?
Anyhow change _ld to ld ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1665707305
More information about the hotspot-dev
mailing list