RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 [v2]

[Patricio Chilano Mateo]

On Fri, 5 Jul 2024 12:32:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Coleen's comments
>>  - David's comments
>
> src/hotspot/share/interpreter/oopMapCache.hpp line 45:
> 
>> 43: // For InterpreterOopMap the bit_mask is allocated in the C heap
>> 44: // to avoid issues with allocations from the resource area that have
>> 45: // to live accross the oop closure (see 8335409). InterpreterOopMap
> 
> We don't usually put bug numbers in the code and after this change nobody will want to move this back to resource area, so putting the bug number as a caution shouldn't be needed.  If one wants to know the details, they can git blame this file.

Removed.

> src/hotspot/share/interpreter/oopMapCache.hpp line 46:
> 
>> 44: // to avoid issues with allocations from the resource area that have
>> 45: // to live accross the oop closure (see 8335409). InterpreterOopMap
>> 46: // should only be created and deleted during same garbage collection.
> 
> Can you add 'the' to "during the same garbage collection."

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20012#discussion_r1666861364
PR Review Comment: https://git.openjdk.org/jdk/pull/20012#discussion_r1666861445