RFR: 8312125: Refactor CDS enum class handling [v2]

Calvin Cheung ccheung at openjdk.org
Fri Jul 5 16:41:32 UTC 2024


On Wed, 3 Jul 2024 19:57:51 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this simple refactoring of the CDS code for handling enum classes. The code is moved to new files cdsEnumKlass.cpp/hpp. There's otherwise no change.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed copyright

Refactoring looks good. I have one suggestion.

src/hotspot/share/cds/cdsEnumKlass.cpp line 136:

> 134:   return true;
> 135: }
> 136: #endif

Suggestion: `#endif INCLUDE_CDS_JAVA_HEAP`

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20013#pullrequestreview-2161016601
PR Review Comment: https://git.openjdk.org/jdk/pull/20013#discussion_r1666987825


More information about the hotspot-dev mailing list