RFR: 8335269: [Graal] occasional timeout in java/lang/StringBuffer/TestSynchronization.java with loom [v2]

[Alan Bateman]

On Mon, 8 Jul 2024 20:04:04 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> test/jdk/java/lang/Thread/virtual/ThreadYield.java line 47:
>> 
>>> 45: import static org.junit.jupiter.api.Assertions.*;
>>> 46: 
>>> 47: class ThreadYield {
>> 
>> This isn't a unit test for Thread.yield so I think it would be better to rename to something specific like ThreadYieldPollsSafepoint (or better name).
>
> How about ThreadPollOnYield?

That would be okay, main thing is to avoid any suggestion that it's a general test for Thread.yield.

>> test/jdk/java/lang/Thread/virtual/ThreadYield.java line 49:
>> 
>>> 47: class ThreadYield {
>>> 48:     static void foo(AtomicBoolean done) {
>>> 49:         synchronized (done) {
>> 
>> When this test makes it to the loom repo then we'll need to change it to pin by other means.
>
> I changed it to use VThreadPinner. I verified the test still times out with Graal.

Thanks, that avoids needing to update when it meets up with the monitor changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20016#discussion_r1670582899
PR Review Comment: https://git.openjdk.org/jdk/pull/20016#discussion_r1670583501