RFR: 8335269: [Graal] occasional timeout in java/lang/StringBuffer/TestSynchronization.java with loom [v5]

Patricio Chilano Mateo pchilanomate at openjdk.org
Thu Jul 11 21:35:28 UTC 2024


On Thu, 11 Jul 2024 21:25:12 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add vm.compMode != Xcomp
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1582:
> 
>> 1580:     freeze_result res = entry->is_pinned() ? freeze_pinned_cs : freeze_pinned_monitor;
>> 1581:     log_develop_trace(continuations)("=== end of freeze (fail %d)", res);
>> 1582:     // Avoid Thread.yield() loops without safepoint polls (see 8335269).
> 
> Is an explicit reference to a JBS issue id like this still recommended practice? After all, it will be a prefix in the merged commit message.

Right, I removed it from the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20016#discussion_r1674716191


More information about the hotspot-dev mailing list