RFR: 8336103: Sharper checks for <init> and <clinit> initializers [v2]

[David Holmes]

On Mon, 15 Jul 2024 09:15:02 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Okay, such a change in behaviour was unexpected for a "cleanup" PR. I'm looking into it now. Perhaps @mlchung can comment?
>
> Yeah, this is not really a cleanup (behaviors stay the same) change. For this particular hunk, keeping the old behavior seems to be unnecessary work. Note that we are also changing the behavior in C2: both in `do_exits` we no longer emit the barriers for `static final` stores in `clinits`, plus EA does not care about `clinits` anymore as well. Those are also behavioral changes.
> 
> If you prefer, I can turn this PR into a behaviorally similar cleanup, and do the behavior changes separately.

I certainly would not want those C2 changes to hidden behind what looks like a cleanup on the surface, so please do separate things out.

BTW Mandy is away for a while so we can't get her input on the original intent here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20120#discussion_r1678756832