RFR: 8300732: Whitebox functions for Metaspace test should use byte size [v2]

[Thomas Stuefe]

On Mon, 15 Jul 2024 19:41:13 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This PR addresses [8300732](https://bugs.openjdk.org/browse/JDK-8300732) switching Whitebox Metaspace test functions to use bytes as opposed to words. 
>> 
>> Testing: 
>> - [x] `test/hotspot/jtreg/runtime/Metaspace` tests pass. 
>> 
>> Thanks, 
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Hard coding values and adding Unit class
>  - whitebox changes based on feedback. Using is_aligned and asserts

Okay, if 32-bit passes. Thanks!

test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocation.java line 56:

> 54:         MetaspaceTestContext context = new MetaspaceTestContext();
> 55:         MetaspaceTestArena arena1 = context.createArena(false, 32L * Unit.valueOf("M").size());
> 56:         MetaspaceTestArena arena2 = context.createArena(true, 32L * Unit.valueOf("M").size());

Why not just `Unit.M.size()` ?

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20039#pullrequestreview-2180404772
PR Review Comment: https://git.openjdk.org/jdk/pull/20039#discussion_r1679500651