RFR: 8300732: Whitebox functions for Metaspace test should use byte size [v2]

Sonia Zaldana Calles szaldana at openjdk.org
Tue Jul 16 14:42:52 UTC 2024


On Tue, 16 Jul 2024 14:18:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Hard coding values and adding Unit class
>>  - whitebox changes based on feedback. Using is_aligned and asserts
>
> test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocation.java line 56:
> 
>> 54:         MetaspaceTestContext context = new MetaspaceTestContext();
>> 55:         MetaspaceTestArena arena1 = context.createArena(false, 32L * Unit.valueOf("M").size());
>> 56:         MetaspaceTestArena arena2 = context.createArena(true, 32L * Unit.valueOf("M").size());
> 
> Why not just `Unit.M.size()` ?

Good point - direct access is less error prone anyway. I can update it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20039#discussion_r1679543890


More information about the hotspot-dev mailing list