RFR: 8336587: failure_handler lldb command times out on macosx-aarch64 core file

[Chris Plummer]

I was looking at the failure_handler output for the lldb command on a macosx-aarch64 core file (it is trying to use lldb to get a back trace of all threads), and noticed it timed out:


----------------------------------------
[2024-07-15 05:15:47] [<snip>/usr/bin/lldb, --core, <snip>/core.92643, <snip>/bin/java, -o, thread backtrace all, -o, quit] timeout=20000 in <snip>
----------------------------------------
(lldb) target create "<snip>/bin/java" --core "<snip>/core.92643"
WARNING: tool timed out: killed process after 20000 ms
----------------------------------------
[2024-07-15 05:16:07] exit code: -2 time: 20163 ms
----------------------------------------


20 seconds is the failure_handler default timeout for all commands. Core files on macosx-aarch64 tend to be very large. This one was over 13gb. On my MBPro it took 30 seconds. I bumped up the timeout to 60 seconds and reproduce the same crash in mach5 (more than once), and it usually took about 55 seconds for the lldb command, but it did succeed with the longer timeout. I think we should change the timeout to event more than 60 seconds just to make sure we won't see timeouts. 120 seconds is probably a good amount.

-------------

Commit messages:
 - Fix comment.
 - Give lldb a much longer timeout.

Changes: https://git.openjdk.org/jdk/pull/20206/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20206&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8336587
  Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/20206.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20206/head:pull/20206

PR: https://git.openjdk.org/jdk/pull/20206