RFR: 8325945: Error reporting should limit the number of String characters printed [v2]

David Holmes dholmes at openjdk.org
Thu Jul 18 03:44:31 UTC 2024


On Wed, 17 Jul 2024 06:25:55 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> AFAICS you start abridging if length is exactly max_length

Where do you see that? I have:

 bool abridge = length > max_length;


>  it may seem just strange to replace a small inner portion with a larger "omitted" text, because then the text plus replacement is larger than the original text,

That is not a practical concern as max_length is expected to be much larger than the replacement text. We don't need the added complexity of the "stretch" zone.

I'm open to changing the omitted text portion though, to include the number of characters omitted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20150#discussion_r1682067434


More information about the hotspot-dev mailing list