RFR: 8325945: Error reporting should limit the number of String characters printed [v4]

[David Holmes]

On Thu, 18 Jul 2024 07:23:16 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comment
>
> src/hotspot/share/classfile/javaClasses.cpp line 799:
> 
>> 797:   if (length > max_length) {
>> 798:     st->print(" (abridged) ");
>> 799:   }
> 
> Do we still need this marker?

See my comment above:
https://github.com/openjdk/jdk/pull/20150#issuecomment-2235749703

> src/hotspot/share/runtime/globals.hpp line 1312:
> 
>> 1310:           "printed with the middle of the string elided.")                  \
>> 1311:           range(2, O_BUFLEN)                                                \
>> 1312:                                                                             \
> 
> This would make sense as a product diagnostic switch. You want to be able to increase this at a customer if needed.

This is modelled after the `MaxElementPrintSize` that precedes it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20150#discussion_r1682353932
PR Review Comment: https://git.openjdk.org/jdk/pull/20150#discussion_r1682354725