RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v5]

[Johan Sjölen]

On Mon, 22 Jul 2024 20:02:40 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> @SoniaZaldana Note that this is very much optional.
>
> Hi folks, thanks for the pointers! I wasn't familiar with X macros and after some time toying around with them, I'm sad to report that I am not a fan (yet!).
> 
> I implemented it and ended up breaking part of the tests. I quickly realized that debugging these is a bit harder for less experienced c++ developers (like myself). 
> 
> So, just wanted to note: 
> - I cleaned up the indentation in this function as it was all wrong. 
> - I didn't get rid of the repetition. Tried to but quickly realized we can't pull the DCmdArgument out of the if statements as they're different types. 
> 
> And note to self, to keep reviewing X macros because they did shorten the code a lot when I implemented them. Perhaps I'll give it another go in a different RFE.
> 
> Sorry it's not what either of you hoped for!

That's fine, thanks for having a go!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20198#discussion_r1687949210