RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v12]

Thu Jul 25 15:31:05 UTC 2024

On Thu, 25 Jul 2024 14:51:22 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> > > good as it's a way of telling people these are FILEs therefore %p is interpreted, rather than just a STRING.
> > 
> > 
> > Hi Kevin,
> > I feel this could be more explicit by updating the manpage to explain the %p substitution rather than updating the type to FILE seeing how users are asked to specify a filename rather than an existing file. What do you think?
> 
> Hi, I was thinking both 8-) I can do the man page task as that is still closed...

Makes sense. I updated the relevant arguments to `FILE`. 

> I can do the man page task as that is still closed...

That'd be great and thank you for your patience with this review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20198#issuecomment-2250681706