RFR: 8325002: Exceptions::fthrow needs to ensure it truncates to a valid utf8 string

David Holmes dholmes at openjdk.org
Sat Jul 27 12:37:32 UTC 2024


On Sat, 27 Jul 2024 12:13:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/utilities/utf8.cpp line 398:
>> 
>>> 396: // byte sequence.
>>> 397: static bool is_starting_byte(unsigned char b) {
>>> 398:   return b >= 0xC0 && b <= 0xEF;;
>> 
>> Do you plan to use this method only for modified UTF-8 or for standard Utf-8 as well? Standard UTF-8 also uses F0-F7 as starting bytes.
>> 
>> Also, remove the double semicolon.
>
> AFAIK the VM only deals with modified UTF-8.

;; fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20345#discussion_r1693951565


More information about the hotspot-dev mailing list