RFR: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap' [v4]

[Kim Barrett]

On Mon, 29 Jul 2024 18:14:59 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> I think when incorporating something like my suggested changes, the PR author can be considered to have reviewed them. The goal is to have some number of people look over the code and approve all the pieces (an author and 2 reviewers). At least, that's my recollection of some prior discussions of situations like this. But I agree it can feel a little incestuous having 2 authors who are playing a reviewer roll for the other's work, and especially when there's some back and forth on it.

I did some asking around about this, and it seems my old info is stale and we should usually have reviewers who are
distinct from any of the contributors.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20296#issuecomment-2257175455