RFR: 8325002: Exceptions::fthrow needs to ensure it truncates to a valid utf8 string [v5]
David Holmes
dholmes at openjdk.org
Tue Jul 30 05:41:08 UTC 2024
> Exceptions::fthrow uses a 1024 byte buffer to format the incoming exception message string, but this may not be large enough, leading to truncation. However, we should ensure we truncate to a valid UTF8 sequence.
>
> The process is explained in the code. Thanks to @RogerRiggs and @djelinski for their suggestions on how to tackle this.
>
> Testing:
> - new gtest exercises the truncation code with the different possibilities for bad truncation
> - tiers 1-3 sanity testing
>
> Thanks.
David Holmes has updated the pull request incrementally with one additional commit since the last revision:
Fix off-by-one error
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20345/files
- new: https://git.openjdk.org/jdk/pull/20345/files/77079058..d7b65bbb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20345&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20345&range=03-04
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/20345.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20345/head:pull/20345
PR: https://git.openjdk.org/jdk/pull/20345
More information about the hotspot-dev
mailing list