RFR: 8337421: RISC-V: client VM build failure after JDK-8335191 [v2]

[Fei Yang]

On Tue, 30 Jul 2024 07:52:03 GMT, Gui Cao <gcao at openjdk.org> wrote:

>> Hi, please help review this patch that fix the client VM build failed for riscv.
>> 
>> Error log for client VM build to see: [JDK-8337421](https://bugs.openjdk.org/browse/JDK-8337421)
>> 
>> The root cause is that MaxVectorSize is defined in COMPILER2 or JVMCI, which is not included in client mode. In addition to this, I have adjusted the functions related to initialization using UseSHA256Intrinsics, UseSHA512Intrinsics, UseMD5Intrinsics, UseChaCha20Intrinsics, UseSHA1Intrinsics, UseAdler32Intrinsics to be under the control of the COMPILER2 macro.  And made related adjustments in VM_Version::c2_initialize().
>> 
>> ### Testing
>> - [x] linux-riscv client VM fastdebug native build
>
> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix for review comments

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 6007:

> 6005:     generate_compare_long_strings();
> 6006: 
> 6007:     generate_string_indexof_stubs();

I think we can put this two under macro `COMPILER2` too. Then we can further remove check for macro `COMPILER2_OR_JVMCI` in this function. I don't think these stubs are ever used by JVMCI which is only partially implemented on this platform for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20386#discussion_r1696524759