RFR: 8337421: RISC-V: client VM build failure after JDK-8335191 [v3]

Fei Yang fyang at openjdk.org
Tue Jul 30 08:48:11 UTC 2024


On Tue, 30 Jul 2024 08:16:44 GMT, Gui Cao <gcao at openjdk.org> wrote:

>> Hi, please help review this patch that fix the client VM build failed for riscv.
>> 
>> Error log for client VM build to see: [JDK-8337421](https://bugs.openjdk.org/browse/JDK-8337421)
>> 
>> The root cause is that MaxVectorSize is defined in COMPILER2 or JVMCI, which is not included in client mode. In addition to this, I have adjusted the functions related to initialization using UseSHA256Intrinsics, UseSHA512Intrinsics, UseMD5Intrinsics, UseChaCha20Intrinsics, UseSHA1Intrinsics, UseAdler32Intrinsics to be under the control of the COMPILER2 macro.  And made related adjustments in VM_Version::c2_initialize().
>> 
>> ### Testing
>> - [x] linux-riscv client VM fastdebug native build
>
> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove check for macro COMPILER2_OR_JVMCI in generate_compiler_stubs function

src/hotspot/cpu/riscv/vm_version_riscv.cpp line 333:

> 331:   // NOTE: Make sure codes dependent on UseRVV are put after MaxVectorSize initialize,
> 332:   //       as there are extra checks inside it which could disable UseRVV
> 333:   //       in some situations.

Please also move this code comment to immediately after initialization of MaxVectorSize. Otherwise looks good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20386#discussion_r1696567820


More information about the hotspot-dev mailing list