RFR: 8333144: docker tests do not work when ubsan is configured [v3]

Christoph Langer clanger at openjdk.org
Wed Jul 31 07:22:41 UTC 2024


On Tue, 30 Jul 2024 13:26:45 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Currently when we run with ubsan - enabled binaries (configure option --enable-ubsan, see [JDK-8298448](https://bugs.openjdk.org/browse/JDK-8298448)), the docker tests do not work.
>> 
>> We find this in the test output
>> 
>> [STDOUT]
>> /jdk/bin/java: error while loading shared libraries: libubsan.so.1: cannot open shared object file: No such file or directory
>> 
>> The container where the test is executed does not contain the ubsan package; we might skip the test in this case.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   install libubsan1 into test container

I think adding libubsan1 to the test container is the best way to go. If it cannot be made conditional on ubsan builds then be it so. Then the Whitebox changes should be removed obviously.

test/hotspot/jtreg/containers/docker/DockerBasicTest.java line 34:

> 32:  *          jdk.jartool/sun.tools.jar
> 33:  * @build HelloDocker
> 34:  * @run driver DockerBasicTest

you remove @build and @run directives from the test - probably not desired.

-------------

Changes requested by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19907#pullrequestreview-2209366794
PR Review Comment: https://git.openjdk.org/jdk/pull/19907#discussion_r1698020822


More information about the hotspot-dev mailing list