RFR: 8333791: Fix memory barriers for @Stable fields [v2]
Vladimir Ivanov
vlivanov at openjdk.org
Wed Jul 31 19:28:34 UTC 2024
On Wed, 31 Jul 2024 19:22:35 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Yes, to access the annotation from test, like `RestrictContended` nearby:
>> https://github.com/openjdk/jdk/blob/97f7c03dd0ff389abefed7ea2a7257bcb42e0754/src/hotspot/share/classfile/classFileParser.cpp#L1960
>>
>> Not sure if putting test classes on bootclasspath would work well with IR tests that are now running in driver mode. I'd prefer to keep the develop flag and keep tests in driver mode and without additional fluff.
>
> `RestrictContended` and `RestrictReservedStack` are product flags.
I'm not saying that `RestrictStable` should be made product. It was a deliberate decision to limit it only to trusted classes.
There are existing tests for `@Stable` (under `test/hotspot/jtreg/compiler/stable/`) and they don't require any special assistance from the JVM.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19635#discussion_r1699000542
More information about the hotspot-dev
mailing list