RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v6]

kuaiwei duke at openjdk.org
Mon Jun 3 06:45:23 UTC 2024


On Fri, 31 May 2024 10:08:47 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment in aarch64.ad
>
> test/hotspot/gtest/aarch64/test_assembler_aarch64.cpp line 211:
> 
>> 209: constexpr uint32_t test_encode_dmb_ld = 0xd50339bf;
>> 210: constexpr uint32_t test_encode_dmb_st = 0xd5033abf;
>> 211: constexpr uint32_t test_encode_dmb    = 0xd5033bbf;
> 
> Can you maybe move these to the top, and use these constants across the test? You would not need the comments like `0xd5033abf, // dmb.ishst` then.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19278#discussion_r1623852788


More information about the hotspot-dev mailing list