RFR: 8332900: RISC-V: refactor nativeInst_riscv.cpp and macroAssembler_riscv.cpp [v4]
Robbin Ehn
rehn at openjdk.org
Mon Jun 3 12:46:03 UTC 2024
On Mon, 3 Jun 2024 12:11:30 GMT, Hamlin Li <mli at openjdk.org> wrote:
> What I want is to let MASM have no dependency on nativeInst, that's one of the principals I stick to in this pr, as dependency on nativeInst from MASM makes no sense from the point of view of code logic, and bidirectional dependency makes code dependency complicated which will also lead to issues of readability and maintainance. And if you are going to do it, I hope to do it thoroughly.
I'm not disagreeing with your intent.
I'm just saying I duplicating the constants is not good solution, and the code in some cases will be worse.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19459#issuecomment-2145110170
More information about the hotspot-dev
mailing list