RFR: 8332900: RISC-V: refactor nativeInst_riscv.cpp and macroAssembler_riscv.cpp [v5]

Robbin Ehn rehn at openjdk.org
Mon Jun 3 17:13:03 UTC 2024


On Mon, 3 Jun 2024 11:42:28 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review the patch?
>> Currently, code in nativeInst_riscv.cpp and macroAssembler_riscv.cpp call each other, which is not right for readability and maintainance.
>> After refactoring, basically only code in nativeInst_riscv.cpp calls code in macroAssembler_riscv.cpp, but not in reverse direction.
>> 
>> Thanks!
>> 
>> * Tests are still running, so far so good.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move

Yea, there is were we disagree, as constants needs to be duplicate there is a depenecy even if you now can remove header.
If guys like, sure. If it is possible for you to wait for the other PR, please do so.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19459#issuecomment-2145727575


More information about the hotspot-dev mailing list