RFR: 8256828: ostream::print_cr() truncates buffer in copy-through case [v2]

[David Holmes]

> Clarifies the behaviour of this function in regards to truncation when adding a CR. Ensures a truncation warning is always issued.
> 
> Adds unit testing for the specialized cases.
> 
> See JBS for discussion of other suggestions.
> 
> Testing: - tiers 1-4
> 
> Thanks

David Holmes has updated the pull request incrementally with two additional commits since the last revision:

 - Use constexpr and add missing definition that some compilers complain about
 - use strncmp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19512/files
  - new: https://git.openjdk.org/jdk/pull/19512/files/6b5aa1c9..e0b0693a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19512&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19512&range=00-01

  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/19512.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19512/head:pull/19512

PR: https://git.openjdk.org/jdk/pull/19512