RFR: 8256828: ostream::print_cr() truncates buffer in copy-through case [v3]

[Thomas Stuefe]

On Tue, 4 Jun 2024 04:17:56 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert constexpr usage
>
> src/hotspot/share/utilities/defaultStream.hpp line 33:
> 
>> 31:   friend void ostream_abort();
>> 32:  public:
>> 33:   class TestSupport;  // Unit test support
> 
> Interesting variant of the "friend class for test support". I never thought of this. An advantage is that its name is scoped to the testee class, so one does not have to think up a good name.

Any reason why you test defaultstream and instread of outputStream?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19512#discussion_r1625319557