RFR: 8332689: RISC-V: Use load instead of trampolines [v4]

Robbin Ehn rehn at openjdk.org
Wed Jun 5 12:38:58 UTC 2024


On Wed, 5 Jun 2024 10:46:01 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Yea, we should probably add a `NativeCall::instruction_size()` but that limit us to have a fixed sized.
>> It would really be good if we could have variable size. E.g. look up size via pc desc.
>
> And underlying problem should be fixed:
> `// When using JVMCI the address might be off by the size of a call instruction.`
> Poking around and guestimate is not the right thing to do.
> 
> It's seem like this only effects frame::safe_for_sender, so it seem like graal is not setting up frames as expected, otherwise this sender_pc would be correct always.

Sent out:
https://github.com/openjdk/jdk/pull/19556

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1627679651


More information about the hotspot-dev mailing list